Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.From #1797856-10: Make toolbar non-sticky, keep it in page flow.
It's lots of JS, a major performance issues on pages with several of them (open a 300+ comment page on d.o and feel the slowness. Then do the same on mobile and wait for 20+ seconds for the page to finish loading).
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | core-js-tableheader-2014309-14.patch | 2.08 KB | nod_ |
| #8 | core-js-tableheader-2014309-8.patch | 2.54 KB | nod_ |
| #3 | core-js-tableheader-2014309-3.patch | 1.61 KB | nod_ |
| core-js-remove-tableheader.patch | 14.04 KB | nod_ |
Comments
Comment #1
nod_tag
Comment #2
ry5n commented+1 on the idea, subject to usability testing. It’s a minor win with comparatively heavy performance costs.
Comment #3
nod_permission page kinda useless without this, so alternate solution: sticky defaults to false.
Comment #5
catchiirc this was added specifically for the permiissions page.
Defaulting to FALSE seems obvious.
Is there are decent (or no worse than) library for this anywhere we could use instead of the custom JS? It's several years since it was added.
Comment #6
nod_I refactored it not long ago, perf is much better than it used to be (especially on scoll events). The alternate future-facing solution would be
position: stickyas shown in #1764912-10: Fix regressions and further improve tableheader.js but that's not really widespread: http://updates.html5rocks.com/2012/08/Stick-your-landings-position-stick...Comment #7
wim leers+1 to default to false. Test fixes should be trivial.
Comment #8
nod_i guess that's where we're going for now.
Comment #9
wim leersCode is good to go.
Are there other places in Drupal core where sticky table headers are valuable? Pinging Bojhan.
Comment #10
wim leersComment #11
yoroy commentedSpeed is an important UX factor, so sounds like the right trade-off to make.
*Edit* I think only on the permissions page it's good to have them on by default because you really need the header labels to make sense of each checkbox. All other tables I say have values that are pretty much self-explanetory.
Comment #12
nod_#8: core-js-tableheader-2014309-8.patch queued for re-testing.
Comment #14
nod_reroll
Comment #15
nod_per #9 and #11
I wish we'd have that on d.o
Comment #16
dries commentedMakes sense to me as well. Committed to 8.x. Thanks!
Comment #18
yesct commentedchanging to use the more common tag, so the less common one can be deleted, so it does not show up in the auto complete and confuse people.