Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Jun 2013 at 20:51 UTC
Updated:
19 Sep 2013 at 04:24 UTC
Jump to comment: Most recent

Comments
Comment #1
PA robot commentedLink to the project page and git clone command are missing in the issue summary, please add them.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #1.0
drupaljaipur commentedproject page and git clone included
Comment #2
ayesh commentedWow - a nice idea!
some of my thoughts:
- There is a handy and popular Captcha module. If you could integrate this module with Captcha module, that would be very useful because Captcha module can take care of form IDs, administration, etc.
- There are some errors reported by ventral review. Please fix them: http://ventral.org/pareview/httpgitdrupalorgsandboxklausi1938730git
In your .info file,
project and versionproperties will be added by Drupal.org packaging system automatically. Also remove the line 9 with the comment. It will be added automatically as well.- It looks like you store the key in the $_SESSION. This will cause the data to rewrite if the user opens the same form in a new browser tab, and expected to submit the other tab first.
You could store almost any variable in the form alter function's $form_state (2nd argument). Drupal will maintain this array no matter how many duplicates are open.
- Rather than naming your theme function
custom_checkboxes, consider prefixing it with your module name to prevent any confusion with other modules. We are not into namespaces yet!-
$output = theme_table($variable);to$output = theme('table', $variable);. This way, we can allow other modules to take over the table theme function. We don't call theme functions directly :)Comment #3
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3.0
PA robot commentedcorrect git clone command
Comment #4
drupaljaipur commentedThanks Ayesh for your suggestions. I will look into these issues.