Coding standards

Issue marked for Tunisian local sprint next week.

I have rerolled the patch against 7.x-2.x latest. See attached

The patch is outdated.

I have created a new patch that will fix all Drupal standards coding errors.

I only have one warning that I did not figure out how to fix it.

--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 16 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------

Only string literals should be passed to t() where possible

I think it's a bad practice using t() function for variable translation. Here are some explanations: http://hojtsy.hu/blog/2011-may-19/drupals-multilingual-problem-why-t-wro...
Common way to translate variables is using i18n module. https://www.drupal.org/node/1113374

- drupal_add_js(array('scroll_to_top' => array('label' => t(variable_get('scroll_to_top_label', 'Back to top')))), 'setting')
+ drupal_add_js(array('scroll_to_top' => array('label' => variable_get('scroll_to_top_label', 'Back to top'))), 'setting')

@Chi
Thank you for the amazing resources.

I have created another patch where will fix ALL Drupal Coding Standards errors.

What is Needs to reroll means ?

Needs reroll means that the code changed and the patch does not apply anymore.
https://www.drupal.org/contributor-tasks/reroll

I can submitted an updated version of the patch. But would be possible to give it a priority so this does not have to be re-rolling over and over again ?

the patch applied cleanly

I will work on this issue

I ran phpcs and phpcbf and fixed most issues.
The ones that still need to be fixed are these:

FILE: /modules/contrib/scroll_to_top/scroll_to_top.module
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 14 | WARNING | Do not use drupal_add_css() in hook_init(), use #attached for CSS and JS in your page/form callback or in
    |         | hook_page_build() instead
 18 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached for CSS and JS in your page/form callback or in
    |         | hook_page_build() instead
 19 | WARNING | Do not use drupal_add_js() in hook_init(), use #attached for CSS and JS in your page/form callback or in
    |         | hook_page_build() instead
 42 | WARNING | Do not use drupal_add_css() in hook_init(), use #attached for CSS and JS in your page/form callback or in
    |         | hook_page_build() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /modules/contrib/scroll_to_top/scroll_to_top.info
-----------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
 5 | ERROR | It's only necessary to declare files[] if they declare a class or interface.
 6 | ERROR | It's only necessary to declare files[] if they declare a class or interface.
-----------------------------------------------------------------------------------------------------------------

Time: 65ms; Memory: 10MB

Since these errors still need to be corrected, I'm changing the status to Needs Work.

Ok, im going for this

Just an update, I applied the last patch and run phpcs as well as phpcbf and what I got was this, as listed below:

FILE: ...t-drupal_useful_scripts-20f10c7ee60f/d7webform/sites/all/modules/scroll_to_top/scroll_to_top.admin.inc
------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
6 | WARNING | PHP version not specified
6 | ERROR | Missing @category tag in file comment
6 | ERROR | Missing @package tag in file comment
6 | ERROR | Missing @author tag in file comment
6 | ERROR | Missing @license tag in file comment
6 | ERROR | Missing @link tag in file comment
10 | ERROR | Missing @return tag in function comment
11 | ERROR | Function name "scroll_to_top_settings" is prefixed with a package name but does not begin
| | with a capital letter
11 | ERROR | Function name "scroll_to_top_settings" is invalid; consider "Scroll_To_Top_settings"
| | instead
17 | WARNING | Line exceeds 85 characters; contains 89 characters
64 | WARNING | Line exceeds 85 characters; contains 171 characters

Please do not consider my last comment, I used the wrong standart, instead of Drupal's.

Ok, so after using phpcs with the right standart, I got the same log as the comment #17.
Worked on it, and now its pushed and fixed.
Changing to needs review status.

I'll review it!

I reviewed the issue with the phpcs and everything looks fine.
The "arrow.png" file shows that the module still works.
The "error_screen_2022-05-16 11-31-59.png" file shows the phpcs error messages.
And lastly, the "correct_screen2022-05-16 11-38-06.png" file shows the phpcs output (which is none) after the last commited work done.

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.