Comments

nod_’s picture

StatusFileSize
new46.34 KB

2.0.3 is out.

nod_’s picture

Title: Update to jQuery 2.0.2 » Update to jQuery 2.0.3
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

The number of changes in between 2.0.2 and 2.0.3 is extremely minimal: http://blog.jquery.com/2013/07/03/jquery-1-10-2-and-2-0-3-released/.

webchick’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

Let's get a quick round of manual testing on at least some of the stuff at https://drupal.org/node/1777342.

wim leers’s picture

Issue tags: +Novice

.

ioskevich’s picture

Assigned: Unassigned » ioskevich
Issue tags: +CodeSprintCIS
ioskevich’s picture

Assigned: Unassigned » ioskevich
Status: Needs work » Needs review

Failed following tests from https://drupal.org/node/1777342:

Views UI filter checkboxes

  1. Select all works for the first time. Once you check/uncheck any of the checkboxes, "Select all" doesn't make any effect.
  2. "Now check all nodetypes, select all should be enabled." - "select all" keeps unchecked

No console errors in both cases.

OLD STUFF THAT NEEDS UPDATING section

node/add/article - user autocompleted field - only returns Admin user, doesn't search for others, so might be a BE bug? No console errros.
OpenID - SKIPPED, N/A
Sticky table header - tested on permissions page, doesn't appear. No console errors.
Clean URLS - SKIPPED, N/A
"Banana" JS snippet - failed, output was "foobar banana !foobar" (Drupal.t() changed?)

All tests performed on Chrome 28.0.1500.95, OSX 10.8.4

ioskevich’s picture

Assigned: ioskevich » Unassigned
Status: Needs review » Needs work
nod_’s picture

Assigned: ioskevich » Unassigned
Status: Needs review » Needs work

I'm curious to know if the issue exists currently too.

nod_’s picture

Status: Needs work » Reviewed & tested by the community

All of those are not a bug with jQuery 2.0.3, they exist currently too.

views ui filter checkbox, seems like legit js bug, probably my fault: #1839130: Refactor modules/views_ui/js/views-admin.js but don't revert it, I'll fix it today.
sticky headers markup doesn't even appear, looks like an issue from PHP
Banana test, no idea, Drupal.t doesn't even use jQuery.

Awesome work ioskevich, thanks :)

nod_’s picture

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Cool, thanks for checking!

Committed and pushed to 8.x. https://drupal.org/node/1966536 already covers the fact that we upgraded to jQuery 2.0, so I think we're done here.

tstoeckler’s picture

Status: Fixed » Needs review
StatusFileSize
new507 bytes

This missed the CHANGELOG.txt entry.

wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Oh, good catch! I had forgotten this was in the change log.

catch’s picture

Priority: Normal » Critical
webchick’s picture

Status: Reviewed & tested by the community » Fixed

<-- nooob. :P

Committed and pushed that to 8.x too. :)

catch’s picture

Priority: Critical » Normal

I totally cross-posted with the original commit, sorry!

Automatically closed -- issue fixed for 2 weeks with no activity.