drupal_container() is deprecated, and all calls in the menu & menu_link modules module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler())

Files: 
CommentFileSizeAuthor
#7 menu-menu_link-drupal-service-2011104-1.patch2.43 KBtidrif
PASSED: [[SimpleTest]]: [MySQL] 55,381 pass(es).
[ View ]
#4 menu_link-drupal-service-2011104-2.patch750 bytestidrif
PASSED: [[SimpleTest]]: [MySQL] 55,324 pass(es).
[ View ]
#2 menu-drupal-service-2011104-1.patch1.7 KBtidrif
PASSED: [[SimpleTest]]: [MySQL] 55,402 pass(es).
[ View ]
#2 menu_link-drupal-service-2011104-1.patch749 bytestidrif
FAILED: [[SimpleTest]]: [MySQL] 55,704 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

tidrif’s picture

Assigned:Unassigned» tidrif
tidrif’s picture

Status:Active» Needs review
StatusFileSize
new749 bytes
FAILED: [[SimpleTest]]: [MySQL] 55,704 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new1.7 KB
PASSED: [[SimpleTest]]: [MySQL] 55,402 pass(es).
[ View ]

Status:Needs review» Needs work

The last submitted patch, menu_link-drupal-service-2011104-1.patch, failed testing.

tidrif’s picture

StatusFileSize
new750 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,324 pass(es).
[ View ]
tidrif’s picture

Status:Needs work» Needs review
tidrif’s picture

#2: menu-drupal-service-2011104-1.patch queued for re-testing.

tidrif’s picture

StatusFileSize
new2.43 KB
PASSED: [[SimpleTest]]: [MySQL] 55,381 pass(es).
[ View ]

Attached is the combined patch for the menu and menu_link modules.

tidrif’s picture

Assigned:tidrif» Unassigned
DmitryDrozdik’s picture

Status:Needs review» Reviewed & tested by the community

Applied and checked, looks good - RTBC

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

DmitryDrozdik’s picture

Status:Fixed» Closed (fixed)