It has been reported a few times that the iFrame used in IE6 is actually visible as a large blank box when the menu pops out. In both instances changed the CSS dimensions of the iFrame have resolved the issue. I am not sure if the 400px size we have now is honestly necessary or not so I'm opening this thread to look into it and get some testers. I have never been able to get the iFrame to show on my copies of IE so I'm hoping we can get this tested by folks who do see it. I'll attach a patch shortly.

CommentFileSizeAuthor
#4 nice_menus-iframe-size-200990-4.patch570 bytesadd1sun

Comments

add1sun’s picture

ooops, meant to post a link to the other issue where this was raised, with some screenies and such. Please continue discussion of this over here though.

http://drupal.org/node/170840

Christefano-oldaccount’s picture

What was the original reason for the 400px size of the iframe?

add1sun’s picture

I don't know the reason for that specific size - it was written before I took over maintaining the module. I assume it was done because we don't know the size of the menu ahead of time and it was guessed that that size would cover the space most menus would cover.

That said, in my local testing if I set the height and width to 20px each, even though that obviously doesn't cover the size of the expanded menu, it still works fine generally and over selects.

So basically I'm trying to figure out a) if we really need an iframe the same size as the menu and, if so, b) is there a better way for us to get that done using JS to "see" the size first and make the iframe exactly the size of the menu rather than randomly guessing something huge.

add1sun’s picture

Status: Active » Needs review
StatusFileSize
new570 bytes

Here is a simple patch for changing the dimensions in the CSS. It is also easy enough to just edit the nice_menus.css. We can give this a shot first since it is the simplest approach - if it works. I'd like a bunch of people to test this (it only effects IE6 so other browsers shouldn't be effected at all) and make sure that the iframe is really invisible and that the menus still work when flying over a form select.

If this doesn't work, I'll look at JS sizing.

Christefano-oldaccount’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. This fixes the iframe problem I had in IE 6.

add1sun’s picture

Status: Reviewed & tested by the community » Fixed

OK, I went ahead and committed this to HEAD and 5. There is a new release 5.x-1.1 with this and the performance patch rolled in.

s.daniel’s picture

Status: Fixed » Postponed (maintainer needs more info)

Just updated the module and while the performance improvement in IE6 is great I am not so happy with this patch.
The bigger Iframe probably was there because on certain menus there is a spot between menu items where the curser is not on a link (border for example/maybe). There in IE the menu disappears. The iframe however fixes this problem. So either there is a better solution available to this issue or there needs to be some info about this in case someone has the same problem.

The site where I use the menu (THANKS at this point! ;) is in development so I cant link to it here send me a message if you want to take a look at it.

add1sun’s picture

Hm, well actually the iFrame was only added to make the menu work over form selects. It didn't exist prior to that issue being discovered so if that is another undesired effect we'll need to take a look. I do know that others have reported the scrolling down and losing the menu thing between items before and not just on IE.

Please do send me the info (use my contact tab) because I would like to look at it but I am starting travel for the holiday week so I may not get much done on this for a week or two.

add1sun’s picture

protramper sent me access info for the site in question. It does disappear at certain points while rolling over. Some menu items are fine and then at a certain point it just blips off. I tried to do the same thing in Garland on my test site though and the menus worked just fine no matter how I rolled over them. This leads me to believe that this is a theme issue and not a bug in Nice Menus per se.

protramper can you change the theme to Garland on your site and see if the same problem happens? If not, we need to open a new issue to troubleshoot that and leave this issue be.

add1sun’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

I'm going to close this issue since it doesn't seem to be the iFrame issue. We can open a new support issue if the problem persists in the custom theme.

s.daniel’s picture

Thanks again to add1sun and sorry I haven't given any updates yet. Just stuffed with work atm.

Once I'll get to it take care of it and find where the issue was I'll post an update here but as I don't have a problem on the site add1sun looked at it after changing the iframe settings it's not #1 on the todo list :p