Closed (fixed)
Project:
Nice Menus
Version:
5.x-1.x-dev
Component:
Browser Compat
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2007 at 17:08 UTC
Updated:
15 Jan 2008 at 19:52 UTC
Jump to comment: Most recent file
Comments
Comment #1
add1sun commentedooops, meant to post a link to the other issue where this was raised, with some screenies and such. Please continue discussion of this over here though.
http://drupal.org/node/170840
Comment #2
Christefano-oldaccount commentedWhat was the original reason for the 400px size of the iframe?
Comment #3
add1sun commentedI don't know the reason for that specific size - it was written before I took over maintaining the module. I assume it was done because we don't know the size of the menu ahead of time and it was guessed that that size would cover the space most menus would cover.
That said, in my local testing if I set the height and width to 20px each, even though that obviously doesn't cover the size of the expanded menu, it still works fine generally and over selects.
So basically I'm trying to figure out a) if we really need an iframe the same size as the menu and, if so, b) is there a better way for us to get that done using JS to "see" the size first and make the iframe exactly the size of the menu rather than randomly guessing something huge.
Comment #4
add1sun commentedHere is a simple patch for changing the dimensions in the CSS. It is also easy enough to just edit the nice_menus.css. We can give this a shot first since it is the simplest approach - if it works. I'd like a bunch of people to test this (it only effects IE6 so other browsers shouldn't be effected at all) and make sure that the iframe is really invisible and that the menus still work when flying over a form select.
If this doesn't work, I'll look at JS sizing.
Comment #5
Christefano-oldaccount commentedLooks good to me. This fixes the iframe problem I had in IE 6.
Comment #6
add1sun commentedOK, I went ahead and committed this to HEAD and 5. There is a new release 5.x-1.1 with this and the performance patch rolled in.
Comment #7
s.daniel commentedJust updated the module and while the performance improvement in IE6 is great I am not so happy with this patch.
The bigger Iframe probably was there because on certain menus there is a spot between menu items where the curser is not on a link (border for example/maybe). There in IE the menu disappears. The iframe however fixes this problem. So either there is a better solution available to this issue or there needs to be some info about this in case someone has the same problem.
The site where I use the menu (THANKS at this point! ;) is in development so I cant link to it here send me a message if you want to take a look at it.
Comment #8
add1sun commentedHm, well actually the iFrame was only added to make the menu work over form selects. It didn't exist prior to that issue being discovered so if that is another undesired effect we'll need to take a look. I do know that others have reported the scrolling down and losing the menu thing between items before and not just on IE.
Please do send me the info (use my contact tab) because I would like to look at it but I am starting travel for the holiday week so I may not get much done on this for a week or two.
Comment #9
add1sun commentedprotramper sent me access info for the site in question. It does disappear at certain points while rolling over. Some menu items are fine and then at a certain point it just blips off. I tried to do the same thing in Garland on my test site though and the menus worked just fine no matter how I rolled over them. This leads me to believe that this is a theme issue and not a bug in Nice Menus per se.
protramper can you change the theme to Garland on your site and see if the same problem happens? If not, we need to open a new issue to troubleshoot that and leave this issue be.
Comment #10
add1sun commentedI'm going to close this issue since it doesn't seem to be the iFrame issue. We can open a new support issue if the problem persists in the custom theme.
Comment #11
s.daniel commentedThanks again to add1sun and sorry I haven't given any updates yet. Just stuffed with work atm.
Once I'll get to it take care of it and find where the issue was I'll post an update here but as I don't have a problem on the site add1sun looked at it after changing the iframe settings it's not #1 on the todo list :p