Files: 
CommentFileSizeAuthor
#6 search-replace_theme-2009666-6.patch1.85 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,598 pass(es). View
#4 2009666-replace_theme_with_drupal_render_in_search-2.patch1.8 KBjiff
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [2009666-replace_theme_with_drupal_render_in_search-2.patch] from [drupal.org]. View
#1 2009666-replace_theme_with_drupal_render_in_search-1.patch1.64 KBaaronott
FAILED: [[SimpleTest]]: [MySQL] 55,426 pass(es), 3 fail(s), and 0 exception(s). View

Comments

aaronott’s picture

Status: Active » Needs review
FileSize
1.64 KB
FAILED: [[SimpleTest]]: [MySQL] 55,426 pass(es), 3 fail(s), and 0 exception(s). View

Status: Needs review » Needs work

The last submitted patch, 2009666-replace_theme_with_drupal_render_in_search-1.patch, failed testing.

thedavidmeister’s picture

$output['suffix']['#markup'] = '</ol>' . drupal_render(array('#theme' => 'pager'));

You can't do this kind of thing with drupal_render() or you'll get fatal errors.

You *must* declare your array and pass it to drupal_render() in two steps as drupal_render() will attempt to modify it by reference.

Eg:

$pager = array('#theme' => 'pager');
drupal_render($pager);
jiff’s picture

Status: Needs work » Needs review
FileSize
1.8 KB
FAILED: [[SimpleTest]]: [MySQL] Fetch test patch: failed to retrieve [2009666-replace_theme_with_drupal_render_in_search-2.patch] from [drupal.org]. View

Status: Needs review » Needs work

The last submitted patch, 2009666-replace_theme_with_drupal_render_in_search-2.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.85 KB
PASSED: [[SimpleTest]]: [MySQL] 55,598 pass(es). View

Replaced theme with drupal_render.

thedavidmeister’s picture

Status: Needs review » Reviewed & tested by the community

this looks good to me

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 33b0337 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.