Files: 
CommentFileSizeAuthor
#8 interdiff-2009658-8.txt117 byteschrisjlee
#8 2009658-menu-replace-theme-w-drupal_render-8.patch1.62 KBchrisjlee
PASSED: [[SimpleTest]]: [MySQL] 55,250 pass(es).
[ View ]
#6 2009658-menu-replace-theme-w-drupal_render-6.patch1.73 KBchrisjlee
FAILED: [[SimpleTest]]: [MySQL] 55,295 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#6 interdiff-2009658-6.txt1.23 KBchrisjlee
#2 drupal_remove_theme_menu_module-2009658-2.patch1.75 KBhelga.chb
PASSED: [[SimpleTest]]: [MySQL] 55,993 pass(es).
[ View ]

Comments

helga.chb’s picture

Assigned:Unassigned» helga.chb

WDG (Ukraine,Kharkov) want to implement this on Code Sprint UA.

helga.chb’s picture

StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,993 pass(es).
[ View ]
helga.chb’s picture

Status:Active» Needs review
helga.chb’s picture

Assigned:helga.chb» Unassigned
Cottser’s picture

Status:Needs review» Needs work

Thanks for working on this @helga.chb! Looks like a great start :)

+++ b/core/modules/menu/menu.admin.incundefined
@@ -287,9 +287,14 @@ function theme_menu_overview_form($variables) {
+      ¶
+      $indent = array(
+        '#theme' => 'indentation',
+        '#size' => $element['#item']['depth'] - 1,
+      );
+      ¶

@@ -303,8 +308,18 @@ function theme_menu_overview_form($variables) {
+  ¶
+  $table = array(
+    '#theme' => 'table',
+    '#header' => $header,
+    '#rows' => $rows,
+    '#attributes' => array(
+      'id' => 'menu-overview',
+    ),
+  );
+  ¶

Trailing whitespace here, should be removed per http://drupal.org/coding-standards#indenting. Spotted with Dreditor.

+++ b/core/modules/menu/menu.admin.incundefined
diff --git a/sites/default/default.settings.php b/sites/default/default.settings.php
old mode 100644
new mode 100755

This mode change should not be part of the patch.

chrisjlee’s picture

Status:Needs work» Needs review
StatusFileSize
new1.23 KB
new1.73 KB
FAILED: [[SimpleTest]]: [MySQL] 55,295 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new1.73 KB
PASSED: [[SimpleTest]]: [MySQL] 54,976 pass(es).
[ View ]

Moving this along. Removed whitespace as requested in #5.

Whoops https://drupal.org/files/2009658-menu-replace-theme-w-drupal_render-5.patch . It's the same as 6. But i forgot to delete it from the list.

The last submitted patch, 2009658-menu-replace-theme-w-drupal_render-6.patch, failed testing.

chrisjlee’s picture

StatusFileSize
new1.62 KB
PASSED: [[SimpleTest]]: [MySQL] 55,250 pass(es).
[ View ]
new117 bytes

Forgot to change the default.settings file mode

Status:Needs review» Needs work

The last submitted patch, 2009658-menu-replace-theme-w-drupal_render-8.patch, failed testing.

Cottser’s picture

Status:Needs work» Needs review
azinoman’s picture

Status:Needs review» Reviewed & tested by the community

I review the patch and uploaded a menu block and everything looks good. This patch works!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b6eb3d4 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.