I was debugging a fail when I realized how slooowwwww the standard profile is for tests. Let's not use it when we don't absolutely have to.

CommentFileSizeAuthor
#7 comment_preview_testing-2009632-7.patch1.65 KBgiammi
#7 comment_preview_testing-2009632-7.interdiff.txt481 bytesgiammi
#2 comment_preview_testing-2009632-1.patch1.71 KBdawehner
#1 comment-2009632-1.patch1.6 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new comment-2009632-1.patch1.6 KB

This goes from 3.5 minutes to 40 seconds for me.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new comment_preview_testing-2009632-1.patch1.71 KB

Let's do it.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Test suite performance

#2: comment_preview_testing-2009632-1.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: +Test suite performance

#2: comment_preview_testing-2009632-1.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentPreviewTest.phpundefined
@@ -32,6 +32,35 @@ public static function getInfo() {
   /**
+   * {@inheritdoc}
+   */
+  function setUp() {

setUp() methods don't have docblocks according to our current standards.

Stupid nitpick, I know, but I'm happy to RTBC after that :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: +Novice, +Needs reroll

Tagging as novice. trivial re-roll.

giammi’s picture

giammi commented
Status: Needs work » Needs review
StatusFileSize
new comment_preview_testing-2009632-7.interdiff.txt481 bytes
new comment_preview_testing-2009632-7.patch1.65 KB

trying...

Status: Needs review » Needs work

The last submitted patch, comment_preview_testing-2009632-7.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Novice, -Needs reroll

Was a testbot problem that got re-tested on qa.d.o, test is green and good to Go. Happy for everything that makes tests a tiny bit faster :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay, faster tests!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.