Spin off from #2001310: Disallow firing hooks during update. That issue is making the update system more robust and testable, but has some tricky code in it that could use more thorough review. To help focus that work, this issue just extracts the part of that one that moves most of the update_module_enable() implementation into a new class: UpdateModuleHandler.

This patch is almost a direct copy/paste of update_module_enable() to UpdateModuleHandler::enable(), except it makes UpdateModuleHandler::enable() conform to ModuleHandlerInterface::enable(), which means there's a little wrapping code retained in update_module_enable() to be cleaned up in the other issue.

Please credit chx on commit, since he wrote the initial patch from which this is extracted.

CommentFileSizeAuthor
update_module_enable.patch10.73 KBeffulgentsia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Note that either this patch, or #2004784-5: Move module install/uninstall implementations into ModuleInstaller will need a reroll after the other one lands. I can reroll either so have no preference as to which is committed first.

Status: Needs review » Needs work

The last submitted patch, update_module_enable.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

update_module_enable.patch queued for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

#2001310: Disallow firing hooks during update is RTBC and will likely go in after the tests passed, can we close this again?

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Status: Needs review » Closed (duplicate)

Not sure what you mean by "again", but yes.