If using #access = FALSE on the form, after ajax requests (e.g. remove image), groups can be gone.

CommentFileSizeAuthor
#5 2007746-er-hide-access-5.patch865 bytesamitaibu
#3 field_access_breaks_create_with_hide-2007746-3.patch634 bytesrbrandon
#1 2007746-er-prepopulate-hide-field-1.patch2 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new 2007746-er-prepopulate-hide-field-1.patch2 KB
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed.

rbrandon’s picture

rbrandon commented
Status: Fixed » Needs review
StatusFileSize
new field_access_breaks_create_with_hide-2007746-3.patch634 bytes

The above patch breaks node creation when hiding fields.
Not sure if this is the correct longterm solution but this fixes the issue in both scenarios.

-RB

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

> The above patch breaks node creation when hiding fields.

I wasn't able to reproduce on a clean installation, what are the steps?

+++ b/entityreference_prepopulate.moduleundefined
@@ -153,7 +153,7 @@ function entityreference_prepopulate_field_access($op, $field, $entity_type, $en
+    return ($settings['action'] == 'hide' && empty($entity->is_new)) ? FALSE : NULL;

I'm not clear about this fix, as we are already inside if ($id) which means this entity is already saved.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new 2007746-er-hide-access-5.patch865 bytes

@rbrandon, I understand now your patch, sorry - I've tested it with admin user, so field_access() didn't kick in.

Here's a patch to fix the issue, we'll add a test as-well as follow-up.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed. The tests would be in another issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.