Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2007052-2.patch | 9.97 KB | thedavidmeister |
#2 | 2007052-interdiff-1-2.txt | 1.01 KB | thedavidmeister |
#1 | 2007052-1.patch | 10.07 KB | thedavidmeister |
Comments
Comment #1
thedavidmeister CreditAttribution: thedavidmeister commentedpatch.
Comment #2
thedavidmeister CreditAttribution: thedavidmeister commentedfix for fatal error.
Comment #4
c4rl CreditAttribution: c4rl commentedRetitling
Comment #5
thedavidmeister CreditAttribution: thedavidmeister commented#2: 2007052-2.patch queued for re-testing.
Comment #6
thedavidmeister CreditAttribution: thedavidmeister commentedComment #7
star-szrI've reviewed this patch a couple times now, looks great to me. I think careful reviews will be more beneficial than manual testing for these patches and had a quick chat with @thedavidmeister about this on IRC just now. I will be updating the issue summary on the meta issue slightly to make the scope of these conversions a bit smaller.
Comment #8
star-szrOkay discussed on IRC, at least this bit could use some manual testing :)
Comment #9
Miroling CreditAttribution: Miroling commentedTaked for manual testing #2009672
Comment #10
Miroling CreditAttribution: Miroling commentedBehaviour in views ui didn't change. Patch working fine.
Comment #11
catchCommitted/pushed to 8.x, thanks!
Comment #12
alexpottlet's not do unnecessary assignments... just do
Therefore...
Same here...
Same here...
Comment #13
alexpottAwesome cross post... back to fixed then...
Comment #14
tim.plunkettdrupal_render() takes the element by reference anyway, we needed those assignments.
Awesome cross post indeed.
Comment #15
thedavidmeister CreditAttribution: thedavidmeister commentedIf you don't do the assignment first you get a fatal error.
I really thought I had left a note about this on the meta issue summary but apparently I didn't, sorry.