Remove leftover 'module' annotation keys and plugin manager processDefinition() to deal with disabled modules during tests [#2006278]

As said in #1780396-64: Namespaces of disabled modules are registered during test runs, removing Drupal\edit\Plugin\EditorManager::processDefinition() was forgotten in #1836008: Remove drupal_classloader() use in Drupal\Core\AnnotatedClassDiscovery.

This is a tiny patch that follows the pattern established by #1836008: Remove drupal_classloader() use in Drupal\Core\AnnotatedClassDiscovery. Originally this was going to be removed by #1903346: Establish a new DefaultPluginManager to encapsulate best practices, but that turns out to no longer be true. Hence this small new issue.

Comment	File	Size	Author
#8	cleanup_module_annotations-2006278-8.patch	11.66 KB	wim leers
#1	cleanup_module_annotations-2006278-1.patch	11.42 KB	wim leers

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 28 May 2013 at 19:10

Title:	Remove leftover plugin manager processDefinition() to deal with disabled modules while running tests	» Remove leftover 'module' annotation keys and plugin manager processDefinition() to deal with disabled modules during tests
Status:	Active	» Needs review

Status	File	Size
new	cleanup_module_annotations-2006278-1.patch	11.42 KB

So it turns out that the 'module' keys were not removed from the "CKEditor" and "Editor" modules either, for an unknown reason. They should have been removed in #1836008: Remove drupal_classloader() use in Drupal\Core\AnnotatedClassDiscovery where possible. E.g. the block and entity plugins use them, but Edit nor Editor nor CKEditor does.