Thanks for updating the module to work with Snapengage's new javascript. After looking over the module I had a couple of edits that I think clarifies the purpose of the new javascript and cleans up the output for those who do not need the advanced functionality.
Clarifications
- Change the checkbox label and description for the "snapengage_widget_advanced" form element to reflect that there is a new version of snapengage's javascript. The rational for this is that there really is not two versions of the javascript. The googleapis script has replaced the old appspot snapabug.js script.
- Change the description of the "snapengage_widget_advanced_script" text field to indicate that it is optional and if you don't need it you can just leave it blank.
Code Change
Add in an extra check to see if something is in the advance script field. If there isn't anything in the field then just load the script and don't print out the advanced javascript snippet as it isn't being used.
I will attempt to submit a patch with the proposed changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | snapengage-clarify-text-cleanup-output-2006222-1.patch | 3.08 KB | moxojo |
Comments
Comment #1
moxojo commentedHere is my attempted patch. First time trying to submit a patch....I think I did it right :).
Thanks!
Comment #2
moxojo commentedComment #3
arnested commentedLooks fine. I fixed some minor code style issues.
Commited as 64b9ff4.
Released as 7.x-1.5.