hey
I tried the feed entity processor and it works fine, when I only want to import items once.
Tried out the update function and mapped a unique target, but the processor does not react on this. It import a lot of duplicates.
I looked at the nodeproccessor and there is lookup for the GUID, but the entityt processor does not have an any code for this.

So update items or imports without duplicates does not work.

CommentFileSizeAuthor
#3 feeds_entity_processor-entity-id-unique-target-2004762-3.patch3.98 KBmegachriz
#3 feeds_entity_processor-entity-id-unique-target-2004762-3-tests-only.patch2.75 KBmegachriz

Comments

bennos’s picture

bennos commented

I tried this patch
http://drupal.org/node/1033202#comment-7414840

an it works with the entity ID.

Missing is case for the "title" and a case for the "GUID".

As the entity processor supports the eck and the basic property of an eck has an title we should support it.
tried to solve it in my dev enviroment, but it does not work well.

Any help would be great.

megachriz’s picture

megachriz
Primary language Dutch
commented
Title: Unique Target does not work » Entity ID as unique target does not work
Project: Feeds » Feeds entity processor
Version: 7.x-2.x-dev » 7.x-1.x-dev
Component: Generic entity processor » Code
Issue summary: View changes

Moving to the Feeds entity processor project, the new home for the generic entity processor.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds_entity_processor-entity-id-unique-target-2004762-3-tests-only.patch2.75 KB
new feeds_entity_processor-entity-id-unique-target-2004762-3.patch3.98 KB

This patch should do the trick. The method existingEntityId() is overidden to lookup the entity ID. A method called testEntityIdAsUniqueTarget() is added to FeedsEntityProcessorBasicTest to test if updating existing entities using the entity ID works as expected.

The patch "feeds_entity_processor-entity-id-unique-target-2004762-3-tests-only.patch" only contains the added test and this patch should demonstrate that the test testEntityIdAsUniqueTarget() fails without the fix.

The last submitted patch, 3: feeds_entity_processor-entity-id-unique-target-2004762-3-tests-only.patch, failed testing.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #3.

  • MegaChriz committed 5746268 on 7.x-1.x 
    Issue #2004762 by MegaChriz: fixed use entity ID as unique target.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.