The test module files
core/modules/aggregator/tests$ ls
aggregator_test_atom.xml aggregator_test_rss091.xml lib
aggregator_test.info.yml aggregator_test_title_entities.xml
aggregator_test.module config
should probably be in their own directory
core/module/aggregator/tests/modules/aggregator_test/
as elsewhere in core.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | drupal-aggregator_move_test_modules-2004022-17.patch | 4.9 KB | ParisLiakos |
| #12 | aggregrator_new_location.patch | 3.32 KB | ollu |
| #5 | aggregrator_new_location.patch | 3.32 KB | ollu |
| #1 | aggregator-test-files-in-own-dir-2004022-1.patch | 7.59 KB | ramlev |
Comments
Comment #1
ramlev commentedI have moved the files into it's own subdirectory.
Comment #2
chrisjlee commentedComment #4
Niklas Fiekas commentedIt appears to me like the new files are missing. Files can be moved with
git mv old-location new-location(orgit add new-location,git rm old-location).git diff --cachedwill then have the correct diff. If not already setgit config diff.renames truewould be helpful before the diff, so that renames are detected as such.Comment #5
ollu commentedFiles moved to new location. Needs review.
Comment #7
Niklas Fiekas commentedLooks like d.o git was down. #5: aggregrator_new_location.patch queued for re-testing.
Comment #9
ollu commented#5: aggregrator_new_location.patch queued for re-testing.
Comment #11
ollu commented#5: aggregrator_new_location.patch queued for re-testing.
Comment #12
ollu commentedThe file was missing empty line at the end so I guess that's the reason for it to fail.
Comment #14
ollu commented#12: aggregrator_new_location.patch queued for re-testing.
Comment #16
ParisLiakos commentedhi. you can extract this from patch here #1957330-28: Make possible for parsers and fetchers to expose configuration through plugins
Comment #17
ParisLiakos commentedComment #19
ParisLiakos commented#17: drupal-aggregator_move_test_modules-2004022-17.patch queued for re-testing.
Comment #20
tim.plunkettIt's always good to be consistent.
Comment #21
alexpottCommitted 0cc160d and pushed to 8.x. Thanks!