The test module files

core/modules/aggregator/tests$ ls
aggregator_test_atom.xml  aggregator_test_rss091.xml          lib
aggregator_test.info.yml  aggregator_test_title_entities.xml
aggregator_test.module    config

should probably be in their own directory
core/module/aggregator/tests/modules/aggregator_test/
as elsewhere in core.

Files: 
CommentFileSizeAuthor
#17 drupal-aggregator_move_test_modules-2004022-17.patch4.9 KBParisLiakos
PASSED: [[SimpleTest]]: [MySQL] 57,448 pass(es).
[ View ]
#12 aggregrator_new_location.patch3.32 KBollu
FAILED: [[SimpleTest]]: [MySQL] 55,996 pass(es), 40 fail(s), and 0 exception(s).
[ View ]
#5 aggregrator_new_location.patch3.32 KBollu
FAILED: [[SimpleTest]]: [MySQL] 56,296 pass(es), 40 fail(s), and 0 exception(s).
[ View ]
#1 aggregator-test-files-in-own-dir-2004022-1.patch7.59 KBramlev
FAILED: [[SimpleTest]]: [MySQL] 54,710 pass(es), 471 fail(s), and 101 exception(s).
[ View ]

Comments

ramlev’s picture

StatusFileSize
new7.59 KB
FAILED: [[SimpleTest]]: [MySQL] 54,710 pass(es), 471 fail(s), and 101 exception(s).
[ View ]

I have moved the files into it's own subdirectory.

chrisjlee’s picture

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, aggregator-test-files-in-own-dir-2004022-1.patch, failed testing.

Niklas Fiekas’s picture

It appears to me like the new files are missing. Files can be moved with git mv old-location new-location (or git add new-location, git rm old-location). git diff --cached will then have the correct diff. If not already set git config diff.renames true would be helpful before the diff, so that renames are detected as such.

ollu’s picture

Status:Needs work» Needs review
StatusFileSize
new3.32 KB
FAILED: [[SimpleTest]]: [MySQL] 56,296 pass(es), 40 fail(s), and 0 exception(s).
[ View ]

Files moved to new location. Needs review.

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, aggregrator_new_location.patch, failed testing.

Niklas Fiekas’s picture

Status:Needs work» Needs review

Looks like d.o git was down. #5: aggregrator_new_location.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, aggregrator_new_location.patch, failed testing.

ollu’s picture

Status:Needs work» Needs review

#5: aggregrator_new_location.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, aggregrator_new_location.patch, failed testing.

ollu’s picture

Status:Needs work» Needs review
Issue tags:+Novice

#5: aggregrator_new_location.patch queued for re-testing.

ollu’s picture

StatusFileSize
new3.32 KB
FAILED: [[SimpleTest]]: [MySQL] 55,996 pass(es), 40 fail(s), and 0 exception(s).
[ View ]

The file was missing empty line at the end so I guess that's the reason for it to fail.

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, aggregrator_new_location.patch, failed testing.

ollu’s picture

Status:Needs work» Needs review

#12: aggregrator_new_location.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice

The last submitted patch, aggregrator_new_location.patch, failed testing.

ParisLiakos’s picture

ParisLiakos’s picture

Status:Needs work» Needs review
StatusFileSize
new4.9 KB
PASSED: [[SimpleTest]]: [MySQL] 57,448 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, drupal-aggregator_move_test_modules-2004022-17.patch, failed testing.

ParisLiakos’s picture

Status:Needs work» Needs review
Issue tags:+Novice
tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

It's always good to be consistent.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 0cc160d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.