Convert format_date to a service

+++ b/core/core.services.ymlundefined
@@ -427,3 +427,6 @@ services:
+  format_date:
+    class: Drupal\Core\Datetime\DateFormats

why not name the service date? then we can add more helper methods in the future

+++ b/core/lib/Drupal/Core/Datetime/DateFormats.phpundefined
@@ -0,0 +1,112 @@
+      $langcode = language(Language::TYPE_INTERFACE)->langcode;

we can inject language manager here and use instead

#9: drupal-2003934-9.patch queued for re-testing.

Rerolled and injected the language manager.

#15: 2003934-15.patch queued for re-testing.

ok sorry for this, but i just saw DrupalDateTime object..and i am sitting here and wondering why this logic shouldnt be in DrupalDateTime::format since it is the drupal specific object?

so i can do:

$date = new DrupalDateTime(REQUEST_TIME);
$date->format('short');

or even introduce a create() method to make this oneliner...

No, we don't want to do that because of #2003892: Convert date formats to config entities

We have a mismatch of service names.

Sorry, totally put the wrong constant in the language change :)

That nicely vouches for the test coverage I guess.

looks great to me:) thanks!

Needs reroll

curl https://drupal.org/files/2003934-25.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6746  100  6746    0     0   6359      0  0:00:01  0:00:01 --:--:--  7588
error: patch failed: core/core.services.yml:440
error: core/core.services.yml: patch does not apply

This patch and #2004506: Move standard_country_list() to Drupal\Core\Locale\Country both tried to add a service to the end of the core.services.yml.
Since it was just a failing of git and absolutely nothing changed, I'm reRTBCing.

Please don't credit me in the commit message.

Committed 0bfe623 and pushed to 8.x. Thanks!