The primary button on a page should be blue, but the styling is being overridden.
This is a regression caused by #1845728: Refactor and introduce generic button CSS styles for forms and links.

Here is how it looked before:
before.png
Here's how it is now:
after.png

Ideally it would look like the dropbutton on node/%/edit, or the action links like "Add node", but this should likely just restore the blue styling first.

CommentFileSizeAuthor
#2 Screen Shot 2013-05-24 at 10.51.23 PM.png10.61 KBdead_arm
#1 button-primary-2003908-1.patch1.76 KBtim.plunkett
after.png9.66 KBdead_arm
before.png9.93 KBdead_arm

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new button-primary-2003908-1.patch1.76 KB

Actually, this seems to just have been CSS slipped in during #1751606: Move published status checkbox next to "Save" that seems unrelated to the issue. (It was the follow-up http://drupalcode.org/project/drupal.git/commit/785ca2b)

The issue was about node/add, and this does not affect that button at ALL. It just alters the styling of unrelated buttons.

I spoke to swentel and he did not work on the CSS in that issue, just the PHP, it seems this was accidentally committed?

This just removes the code line for line.

dead_arm’s picture

dead_arm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2013-05-24 at 10.51.23 PM.png10.61 KB

Looks good. Blue primary button style is back with the patch.

With patch:

Screen Shot 2013-05-24 at 10.51.23 PM.png

carwin’s picture

carwin commented

Looks much better, thanks for fixing this @tim.plunkett

dries’s picture

dries commented
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Note that I don't consider this to be 'major'; setting to 'normal'.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.