DialogController.php introduced a new namespace Drupal\core with a lowercase c. Minor patch to set it to uppercase C Core.

DialogController-namespace-fix.patch570 bytesMixologic
PASSED: [[SimpleTest]]: [MySQL] 56,084 pass(es). View


Mixologic’s picture

Status:Active» Needs review

Oh, should have marked this needs review

Status:Needs review» Needs work

The last submitted patch, DialogController-namespace-fix.patch, failed testing.

Mixologic’s picture

Status:Needs work» Needs review
Mixologic’s picture

andymartha’s picture

Status:Needs review» Reviewed & tested by the community

I can confirm that after applying patch DialogController-namespace-fix.patch to a fresh installation of Drupal 8.x-dev by Mixologic in #1, no changes in functionality to ajax-type pages happened. These were: create a view using ajax paging, using the overlay, inserting images and using CKeditor. If you can think of other core items that use ajax dialog, let me know so that I can test. Also, the referenced file was changed to produce its capital C. Thanks for patching!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed e99a83e and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.