Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 May 2013 at 20:11 UTC
Updated:
29 Jul 2014 at 22:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
broeker commentedworking on it
Comment #2
broeker commentedComment #4
zschmid commentedI believe the addLongerThan function should be public
Comment #5
broeker commentedAdded public to addLongerThan function
Comment #6
heddnLooks good.
Comment #7
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opLongerThan - i'm okay with adding the Than here as this is what it does.
Comment #8
broeker commentedChanged op_longer to opLongerThan per comment in #7 . . .
Comment #9
heddnFixing title
Comment #10
dawehnerThanks for your work.
Method should be protected
Comment #11
broeker commentedI was unclear whether this should be a public or protected function but per dawehner I've now changed it to a protected method:
Comment #12
dawehnerPerfect
Comment #13
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #14
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.