Remove drupal_add_css() from block module page callbacks - use #attached instead.

Meta issue: http://drupal.org/node/1839338

CommentFileSizeAuthor
#1 2003564-remove-drupal_add_css.patch525 bytesmanarth

Comments

manarth’s picture

manarth commented
Status: Active » Needs review
StatusFileSize
new 2003564-remove-drupal_add_css.patch525 bytes

Patch swaps the string return for a render array, and moves drupal_add_css to #attached.

Status: Needs review » Needs work

The last submitted patch, 2003564-remove-drupal_add_css.patch, failed testing.

manarth’s picture

manarth commented
Status: Needs work » Needs review

#1: 2003564-remove-drupal_add_css.patch queued for re-testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove drupal_add_css from Block - use #attached » Remove drupal_add_css() from block.module — use #attached
Status: Needs review » Reviewed & tested by the community

Manually tested, works correctly. Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.