Files: 
CommentFileSizeAuthor
#14 views_rename_op_empty-2003556-14.patch5.62 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,411 pass(es). View
#12 views_rename_op_empty-2003556-12.patch5.28 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] 55,348 pass(es), 1 fail(s), and 0 exception(s). View
#10 views_rename_op_empty-2003556-10.patch5.36 KBnathangervais
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in views_rename_op_empty-2003556-10.patch. View
#8 views_rename_op_empty-2003556-8.patch5.25 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,868 pass(es). View
#2 drupal-camelcase-replace-2003556-7451770.patch5.54 KBbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 57,813 pass(es). View

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie

taking this with sillygwailo

baldwinlouie’s picture

FileSize
5.54 KB
PASSED: [[SimpleTest]]: [MySQL] 57,813 pass(es). View

attaching patch

baldwinlouie’s picture

Status: Active » Needs review

changing to needs review

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2003556-7451770.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
baldwinlouie’s picture

dawehner’s picture

Status: Needs review » Needs work

This probably should get protected.

nathangervais’s picture

Assigned: baldwinlouie » nathangervais
Status: Needs work » Needs review
FileSize
5.25 KB
PASSED: [[SimpleTest]]: [MySQL] 55,868 pass(es). View

Rerolled patch with protected modifiers, from latest head.

dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/GroupByNumeric.phpundefined
@@ -44,7 +44,7 @@ function op_simple($field) {
-  function op_empty($field) {
+  protected function addEmpty($field) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/InOperator.phpundefined
@@ -125,13 +125,13 @@ function operators() {
-          'method' => 'op_empty',
+          'method' => 'addEmpty',

Let's go with opEmpty.

nathangervais’s picture

Title: Rename Views method op_empty() to addEmpty() » Rename Views method op_empty() to opEmpty()
Status: Needs work » Needs review
FileSize
5.36 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid patch format in views_rename_op_empty-2003556-10.patch. View

Patch rerolled. Renamed to opEmpty, updating bug title.

Status: Needs review » Needs work

The last submitted patch, views_rename_op_empty-2003556-10.patch, failed testing.

nathangervais’s picture

Status: Needs work » Needs review
FileSize
5.28 KB
FAILED: [[SimpleTest]]: [MySQL] 55,348 pass(es), 1 fail(s), and 0 exception(s). View

Rerolled Patch.

Status: Needs review » Needs work

The last submitted patch, views_rename_op_empty-2003556-12.patch, failed testing.

SpartyDan’s picture

Assigned: nathangervais » Unassigned
Status: Needs work » Needs review
FileSize
5.62 KB
PASSED: [[SimpleTest]]: [MySQL] 57,411 pass(es). View

re-roll

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6be4fdb and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.