Remove drupal_add_css() from Help page callbacks - use #attached instead.

Meta issue: http://drupal.org/node/1839338

Files: 
CommentFileSizeAuthor
#1 2003524-remove-drupal_add_css.patch1.02 KBmanarth
PASSED: [[SimpleTest]]: [MySQL] 55,871 pass(es). View

Comments

manarth’s picture

Status: Active » Needs review
FileSize
1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 55,871 pass(es). View

Patch swaps the string return for a render array, and moves drupal_add_css to #attached.

Status: Needs review » Needs work

The last submitted patch, 2003524-remove-drupal_add_css.patch, failed testing.

manarth’s picture

Status: Needs work » Needs review

#1: 2003524-remove-drupal_add_css.patch queued for re-testing.

Wim Leers’s picture

Title: Remove drupal_add_css from Help - use #attached » Remove drupal_add_css from() help.module — use #attached
Status: Needs review » Reviewed & tested by the community

Manually tested, works correctly. Thanks!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.