Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 views-rename_group_multiple_exposed_input-2003508-7.patch1.63 KBjeroent
#2 core-groupMultipleExposedInput_replace-2003508.patch1.62 KBraycascella

Comments

raycascella’s picture

raycascella
he/him
commented
Assigned: Unassigned » raycascella

Working on issue at DC portland.

raycascella’s picture

raycascella
he/him
commented
Status: Active » Needs review
StatusFileSize
new core-groupMultipleExposedInput_replace-2003508.patch1.62 KB

My first patch. Hooray! Please work =-D

raycascella’s picture

raycascella
he/him
commented
Assigned: raycascella » Unassigned

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, core-groupMultipleExposedInput_replace-2003508.patch, failed testing.

raycascella’s picture

raycascella
he/him
commented
Status: Needs work » Needs review

#2: core-groupMultipleExposedInput_replace-2003508.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, core-groupMultipleExposedInput_replace-2003508.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-rename_group_multiple_exposed_input-2003508-7.patch1.63 KB

rename group_multiple_exposed_input to groupMultipleExposedInput.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

marking as needs review.

raycascella’s picture

raycascella
he/him
commented

Odd, no functionality was changed, yet it passed on the 3rd go around. Delay from the testing queue backup at DrupalCon?

EDIT: Also, thank you for updating the function names to keep them on standard. Completely slipped my mind with all of the sprint excitement in Portland. =-D

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Probably because of: #1987952: Blocks are not rendered in order by weight

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 686a2ef and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.