Files: 
CommentFileSizeAuthor
#12 rename_views_method-2003496-12.patch39.84 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,581 pass(es). View
#12 interdiff.txt617 bytesmarlatt
#9 rename_views_method-2003496-9.patch39.89 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,080 pass(es). View
#4 Rename_Views_method-2003496-4.patch11.81 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#2 Rename_Views_method-2003496-2.patch17.04 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

NonProfit’s picture

Assigned: Unassigned » NonProfit
NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
17.04 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch created.

NonProfit’s picture

Assigned: Unassigned » NonProfit
Status: Needs review » Active

Need to reroll. get_value_options() improperly changed .

NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
11.81 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003496-4.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Needs work

Needs an access modifier.

marlatt’s picture

Assigned: Unassigned » marlatt

Working..

marlatt’s picture

Assigned: marlatt » Unassigned
Status: Needs work » Needs review
FileSize
39.89 KB
PASSED: [[SimpleTest]]: [MySQL] 56,080 pass(es). View

Previous patch would not apply, no interdiff created. All methods updated and access modifiers created.

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/Counter.phpundefined
@@ -41,9 +41,9 @@ public function query() {
+   * Overrides Drupal\views\Plugin\views\field\FieldPluginBas::getValue()

Let's do an @inheritdoc ... well at it should have been FieldPluginBase :) but just here for now

dawehner’s picture

Status: Needs review » Needs work
marlatt’s picture

FileSize
617 bytes
39.84 KB
PASSED: [[SimpleTest]]: [MySQL] 56,581 pass(es). View

I hope this is correct, I'm still getting to know some of the best practices. I apologize ahead of time.

marlatt’s picture

Status: Needs work » Needs review

Changing status.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Please don't apologize! It's just a code review :)

webchick’s picture

Title: Rename Views method get_value() to getValue() » Change notice: Rename Views method get_value() to getValue()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title: Change notice: Rename Views method get_value() to getValue() » Rename Views method get_value() to getValue()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.