Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#12 rename_views_method-2003496-12.patch39.84 KBmarlatt
#12 interdiff.txt617 bytesmarlatt
#9 rename_views_method-2003496-9.patch39.89 KBmarlatt
#4 Rename_Views_method-2003496-4.patch11.81 KBnonprofit
#2 Rename_Views_method-2003496-2.patch17.04 KBnonprofit

Comments

nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003496-2.patch17.04 KB

Patch created.

nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
Status: Needs review » Active

Need to reroll. get_value_options() improperly changed .

nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003496-4.patch11.81 KB

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003496-4.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Needs an access modifier.

marlatt’s picture

marlatt commented
Assigned: Unassigned » marlatt

Working..

marlatt’s picture

marlatt commented
Assigned: marlatt » Unassigned
Status: Needs work » Needs review
StatusFileSize
new rename_views_method-2003496-9.patch39.89 KB

Previous patch would not apply, no interdiff created. All methods updated and access modifiers created.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/Counter.phpundefined
@@ -41,9 +41,9 @@ public function query() {
+   * Overrides Drupal\views\Plugin\views\field\FieldPluginBas::getValue()

Let's do an @inheritdoc ... well at it should have been FieldPluginBase :) but just here for now

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
marlatt’s picture

marlatt commented
StatusFileSize
new interdiff.txt617 bytes
new rename_views_method-2003496-12.patch39.84 KB

I hope this is correct, I'm still getting to know some of the best practices. I apologize ahead of time.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review

Changing status.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Please don't apologize! It's just a code review :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method get_value() to getValue() » Change notice: Rename Views method get_value() to getValue()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Rename Views method get_value() to getValue() » Rename Views method get_value() to getValue()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.

Automatically closed -- issue fixed for 2 weeks with no activity.