Files: 
CommentFileSizeAuthor
#6 2003484-rename-get_token_values_recursive.patch1.7 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,818 pass(es).
[ View ]
#2 2003484-rename-get_token_values_recursive.patch1.69 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,906 pass(es).
[ View ]

Comments

sillygwailo’s picture

Assigned:Unassigned» sillygwailo

Taking this with baldwinlouie.

sillygwailo’s picture

Status:Active» Needs review
StatusFileSize
new1.69 KB
PASSED: [[SimpleTest]]: [MySQL] 55,906 pass(es).
[ View ]

Patch attached.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003484-rename-get_token_values_recursive.patch, failed testing.

sillygwailo’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1537,7 +1537,7 @@ function get_render_tokens($item) {
+  function getTokenValuesRecursive(array $array, array $parent_keys = array()) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

If the above is fixed, the patch is ok and ready for RTBC.

sillygwailo’s picture

Status:Needs work» Needs review
StatusFileSize
new1.7 KB
PASSED: [[SimpleTest]]: [MySQL] 55,818 pass(es).
[ View ]

Re-rolled with protected.

oenie’s picture

Status:Needs review» Reviewed & tested by the community
Issue tags:-VDC

Looks good to me now !

jibran’s picture

Issue tags:+VDC

Adding VDC tag.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed df13368 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.