Files: 
CommentFileSizeAuthor
#6 2003462-06-rename-operator_submit-to-operatorSubmit.patch1.18 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es). View
#2 2003462-02-rename-operator_submit-to-operatorSubmit.patch1.17 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] 55,740 pass(es), 1 fail(s), and 0 exception(s). View
#1 2003462-01-rename-operator_submit-to-operatorSubmit.patch1.17 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

SpartyDan’s picture

Status: Active » Needs review
FileSize
1.17 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

renamed operator_submit to operatorSubmit

SpartyDan’s picture

FileSize
1.17 KB
FAILED: [[SimpleTest]]: [MySQL] 55,740 pass(es), 1 fail(s), and 0 exception(s). View

changed functions to public functions

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003462-02-rename-operator_submit-to-operatorSubmit.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
elvis2’s picture

Status: Needs review » Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

FileSize
1.18 KB
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es). View

Added access modifier.

tvlooy’s picture

Status: Needs work » Needs review
elvis2’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a39c996 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.