Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 2003386-01-page_feed_display_options.patch1.17 KBSpartyDan
#2 rename-pagefeedisplayoptions-2003386-2.patch1.17 KBilleace

Comments

illeace’s picture

illeace commented

Working at this at Drupalcon code sprints.

illeace’s picture

illeace commented
StatusFileSize
new rename-pagefeedisplayoptions-2003386-2.patch1.17 KB
illeace’s picture

illeace commented
Status: Active » Needs review
SpartyDan’s picture

SpartyDan commented
StatusFileSize
new 2003386-01-page_feed_display_options.patch1.17 KB

Patch to change page_feed_display_options() to pageFeedDisplayOptions()

illeace’s picture

illeace commented

Sorry, Dan. I didn't mean to steal your bug.

SpartyDan’s picture

SpartyDan commented

No worries. I posted my comment and patch without first refreshing my browser. Our patches are identical so that means we are both right. :-)

illeace’s picture

illeace commented

This was my first core patch, so I was very glad to see they were the same. :)

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003386-01-page_feed_display_options.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#4: 2003386-01-page_feed_display_options.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fe3d859 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.