Files: 
CommentFileSizeAuthor
#4 views_rename_function-2003352-4.patch2.2 KBericthelast
PASSED: [[SimpleTest]]: [MySQL] 57,559 pass(es).
[ View ]
#2 views_rename_function-2003352-2.patch2.19 KBericthelast
PASSED: [[SimpleTest]]: [MySQL] 55,707 pass(es).
[ View ]

Comments

ericthelast’s picture

Assigned:Unassigned» ericthelast

Working on this now.

ericthelast’s picture

Status:Active» Needs review
StatusFileSize
new2.19 KB
PASSED: [[SimpleTest]]: [MySQL] 55,707 pass(es).
[ View ]
elvis2’s picture

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

ericthelast’s picture

Status:Needs work» Needs review
StatusFileSize
new2.2 KB
PASSED: [[SimpleTest]]: [MySQL] 57,559 pass(es).
[ View ]

Thanks elvis2, we didn't even look at that in depth at the sprint.

oenie’s picture

Title:Rename Views method reduce_value_options() to reduceValueOptions()» Rename Views method() to reduceValueOptions()
Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 1c61902 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.