Files: 
CommentFileSizeAuthor
#9 views-rename_render_as_link-2003348-9.patch1.38 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,228 pass(es). View
#7 views-core-renderAsLink-2003348-07.patch1.38 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 55,614 pass(es). View
#4 views-renderAsLink-2003348-4.patch1.37 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,198 pass(es). View
#2 views-2003348-renderAsLink.patch1.36 KBphenaproxima
FAILED: [[SimpleTest]]: [MySQL] 55,731 pass(es), 1 fail(s), and 0 exception(s). View

Comments

phenaproxima’s picture

Assigned: Unassigned » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
1.36 KB
FAILED: [[SimpleTest]]: [MySQL] 55,731 pass(es), 1 fail(s), and 0 exception(s). View

Patch passed all field handler tests on my localhost.

Status: Needs review » Needs work

The last submitted patch, views-2003348-renderAsLink.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.37 KB
PASSED: [[SimpleTest]]: [MySQL] 57,198 pass(es). View

Rename render_as_link function to renderAsLink.

oenie’s picture

Unfortunately, the patch doesn't apply anymore.
You'll need to reroll it.

oenie’s picture

Status: Needs review » Needs work
SpartyDan’s picture

Status: Needs work » Needs review
FileSize
1.38 KB
PASSED: [[SimpleTest]]: [MySQL] 55,614 pass(es). View

re-rolled

dawehner’s picture

Status: Needs review » Needs work

I consider this as a usecase for protected.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.38 KB
PASSED: [[SimpleTest]]: [MySQL] 56,228 pass(es). View

Added protected access modifier as mentioned by dawehner.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you very much.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 631d0da and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.