Files: 
CommentFileSizeAuthor
#5 rename_views_method-2003334-5.patch3.14 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 57,398 pass(es).
[ View ]
#5 interdiff.txt950 bytesmarlatt
#2 views-2003334-renderGrouping.patch3.13 KBphenaproxima
FAILED: [[SimpleTest]]: [MySQL] 55,707 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

phenaproxima’s picture

Assigned:Unassigned» phenaproxima
phenaproxima’s picture

Assigned:phenaproxima» Unassigned
Status:Active» Needs review
StatusFileSize
new3.13 KB
FAILED: [[SimpleTest]]: [MySQL] 55,707 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Patch attached; for whatever it's worth, it passed all the tests for Views style plugins on my localhost.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -519,7 +519,7 @@ function render_grouping_sets($sets, $level = 0) {
+  function renderGrouping($records, $groupings = array(), $group_rendered = NULL) {

Add the access modifier public in front of the function declaration. To adher to the new OOP standards and since it's being called directly on an object from the outside (in core/modules/views/lib/Drupal/views/Tests/Plugin/StyleTest.php)

Status:Needs review» Needs work

The last submitted patch, views-2003334-renderGrouping.patch, failed testing.

marlatt’s picture

Status:Needs work» Needs review
StatusFileSize
new950 bytes
new3.14 KB
PASSED: [[SimpleTest]]: [MySQL] 57,398 pass(es).
[ View ]

Added access modifier.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed cdb78e0 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.