Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#7 | 2003332-6.patch | 1.49 KB | jibran |
#4 | views-2003332-renderGroupingSets-2003332-04.patch | 1.5 KB | FredericoT |
#2 | Rename_Views_method-2003332-2.patch | 1.51 KB | NonProfit |
Comments
Comment #1
NonProfit CreditAttribution: NonProfit commentedComment #2
NonProfit CreditAttribution: NonProfit commentedPatch created
Comment #4
FredericoT CreditAttribution: FredericoT commentedComment #5
oenie CreditAttribution: oenie commentedUnfortunately we need a reroll, the patch doesn't apply anymore.
Comment #6
FredericoT CreditAttribution: FredericoT commentedThis is my first time attempting a reroll, but while following the instructions on the link you provided. Step 7 didn't give any conflicts on my patch.
Wouldn't that mean it's ok? Or perhaps more likely, I didn't follow the instructions correctly then?
Comment #7
jibranreroll
Comment #9
SpartyDan CreditAttribution: SpartyDan commented#7: 2003332-6.patch queued for re-testing.
Comment #10
oenie CreditAttribution: oenie commentedLooks good to me now !
Apart from a minor issue with a comment reference:
core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.php, line 93:
* @see StylePluginBase::render_grouping_sets()
Comment #11
alexpottCommitted bf36b09 and pushed to 8.x. Thanks!
Hmmm... due to #10 this should have gone to needs work since that is API documentation that would have broke api.d.o - fixed during commit in interests of getting stuff done(tm)...