Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 2003332-6.patch1.49 KBjibran
#4 views-2003332-renderGroupingSets-2003332-04.patch1.5 KBFredericoT
#2 Rename_Views_method-2003332-2.patch1.51 KBnonprofit

Comments

nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003332-2.patch1.51 KB

Patch created

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003332-2.patch, failed testing.

FredericoT’s picture

FredericoT commented
Status: Needs work » Needs review
StatusFileSize
new views-2003332-renderGroupingSets-2003332-04.patch1.5 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

FredericoT’s picture

FredericoT commented

This is my first time attempting a reroll, but while following the instructions on the link you provided. Step 7 didn't give any conflicts on my patch.
Wouldn't that mean it's ok? Or perhaps more likely, I didn't follow the instructions correctly then?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 2003332-6.patch1.49 KB

reroll

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003332-6.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#7: 2003332-6.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

Apart from a minor issue with a comment reference:

core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.php, line 93:
* @see StylePluginBase::render_grouping_sets()

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bf36b09 and pushed to 8.x. Thanks!

Hmmm... due to #10 this should have gone to needs work since that is API documentation that would have broke api.d.o - fixed during commit in interests of getting stuff done(tm)...

Automatically closed -- issue fixed for 2 weeks with no activity.