Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 VDC-Rename_render_text-2003328-6.patch2.4 KBtvlooy
#2 VDC-Rename_render_text-2003328-2.patch2.39 KBseantwalsh

Comments

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented
Assigned: Unassigned » seantwalsh
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented
StatusFileSize
new VDC-Rename_render_text-2003328-2.patch2.39 KB

Replaced 7 instances of render_text with renderText.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented
Status: Active » Needs review

Updated as I forgot to change to needs review.

elvis2’s picture

elvis2 commented
Status: Needs review » Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

tvlooy commented
Assigned: seantwalsh » tvlooy

Work in progress

tvlooy’s picture

tvlooy commented
Assigned: tvlooy » Unassigned
Status: Needs work » Needs review
StatusFileSize
new VDC-Rename_render_text-2003328-6.patch2.4 KB

Added the access modifiers.

elvis2’s picture

elvis2 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f6e4b9b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.