Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seantwalsh’s picture

Assigned: Unassigned » seantwalsh
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

Replaced 7 instances of render_text with renderText.

seantwalsh’s picture

Status: Active » Needs review

Updated as I forgot to change to needs review.

elvis2’s picture

Status: Needs review » Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

Assigned: seantwalsh » tvlooy

Work in progress

tvlooy’s picture

Assigned: tvlooy » Unassigned
Status: Needs work » Needs review
FileSize
2.4 KB

Added the access modifiers.

elvis2’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed f6e4b9b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.