Files: 
CommentFileSizeAuthor
#6 VDC-Rename_render_text-2003328-6.patch2.4 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 57,372 pass(es).
[ View ]
#2 VDC-Rename_render_text-2003328-2.patch2.39 KBcrowdcg
PASSED: [[SimpleTest]]: [MySQL] 55,806 pass(es).
[ View ]

Comments

crowdcg’s picture

Assigned:Unassigned» crowdcg
Issue tags:+portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

crowdcg’s picture

StatusFileSize
new2.39 KB
PASSED: [[SimpleTest]]: [MySQL] 55,806 pass(es).
[ View ]

Replaced 7 instances of render_text with renderText.

crowdcg’s picture

Status:Active» Needs review

Updated as I forgot to change to needs review.

elvis2’s picture

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

Assigned:crowdcg» tvlooy

Work in progress

tvlooy’s picture

Assigned:tvlooy» Unassigned
Status:Needs work» Needs review
StatusFileSize
new2.4 KB
PASSED: [[SimpleTest]]: [MySQL] 57,372 pass(es).
[ View ]

Added the access modifiers.

elvis2’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f6e4b9b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.