Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 2003320-8.patch1.23 KBjibran
#2 drupal-reset-form-2003320.patch1.22 KBgdf

Comments

gdf’s picture

gdf commented
Assigned: Unassigned » gdf
gdf’s picture

gdf commented
Status: Active » Needs review
StatusFileSize
new drupal-reset-form-2003320.patch1.22 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-reset-form-2003320.patch, failed testing.

gdf’s picture

gdf commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: drupal-reset-form-2003320.patch queued for re-testing.

gdf’s picture

gdf commented
Assigned: gdf » Unassigned

retest was successful - code is not related, and it was a very, very busy day for testBot

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/drupal-reset-form-2003320.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1249  100  1249    0     0   3440      0 --:--:-- --:--:-- --:--:--  6643
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.php:273
error: core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.php: patch does not apply
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 2003320-8.patch1.23 KB

re-roll

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003320-8.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#8: 2003320-8.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 26c5f09 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.