Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-core-rename-sanitize_columns-2003310-06.patch1.79 KBSpartyDan
#4 views-core-rename-sanitize_columns-2003310-04.patch1.78 KBSpartyDan
#2 views-2003310-sanitizeColumns.patch1.78 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2003310-sanitizeColumns.patch1.78 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -185,7 +185,7 @@ function build_sort_post() {
+  function sanitizeColumns($columns, $fields = NULL) {

Add public access modifier in front of the function to adhere to the new OOP standards.

All occurrences are replaced, so the corrected patch should be RTBC.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-rename-sanitize_columns-2003310-04.patch1.78 KB

Added public access modifier in front of the function to adhere to the new OOP standards.

Status: Needs review » Needs work

The last submitted patch, views-core-rename-sanitize_columns-2003310-04.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-rename-sanitize_columns-2003310-06.patch1.79 KB

re-rolled

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Cool

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9ae13bc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.