Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 views-2003300-setGroupOperator-2003300-08.patch1.39 KBFredericoT
#2 views-2003300-setGroupOperator.patch1.38 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2003300-setGroupOperator.patch1.38 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-2003300-setGroupOperator.patch, failed testing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Status: Needs work » Needs review

#2: views-2003300-setGroupOperator.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views-2003300-setGroupOperator.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review

#2: views-2003300-setGroupOperator.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, views-2003300-setGroupOperator.patch, failed testing.

FredericoT’s picture

FredericoT commented
Status: Needs work » Needs review
StatusFileSize
new views-2003300-setGroupOperator-2003300-08.patch1.39 KB
oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/views-2003300-setGroupOperator-2003300-08.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1420  100  1420    0     0   3973      0 --:--:-- --:--:-- --:--:--  8068
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.php:154
error: core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:1039
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Fixed

I think it is committed 27c5c69 .

Automatically closed -- issue fixed for 2 weeks with no activity.