Files: 
CommentFileSizeAuthor
#2 Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch1.87 KBdbcollies
PASSED: [[SimpleTest]]: [MySQL] 56,467 pass(es). View

Comments

dbcollies’s picture

Assigned: Unassigned » dbcollies
dbcollies’s picture

Status: Active » Needs review
FileSize
1.87 KB
PASSED: [[SimpleTest]]: [MySQL] 56,467 pass(es). View

Status: Needs review » Needs work
Issue tags: -Novice, -VDC
dbcollies’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC
dbcollies’s picture

I think that there is something wrong with the test itself. Even on unpatched code, the test fails randomly for me. I have not yet tracked down what might be failing with the test.

I don't see how this patch could be causing this sort of error

dbcollies’s picture

Status: Needs work » Needs review
Issue tags: -Novice, -VDC

Status: Needs review » Needs work
dbcollies’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
dbcollies’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Title: Rename Views method set_override_options() to setOverrideOptions() » Rename Views method lgtm() to setOverrideOptions()
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

oenie’s picture

Title: Rename Views method lgtm() to setOverrideOptions() » Rename Views method set_override_options() to setOverrideOptions()

Oops.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed dd87cbc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.