Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#2 Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch1.87 KBdbcollies

Comments

dbcollies’s picture

dbcollies commented
Assigned: Unassigned » dbcollies
dbcollies’s picture

dbcollies commented
Status: Active » Needs review
StatusFileSize
new Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch1.87 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch, failed testing.

dbcollies’s picture

dbcollies commented
Status: Needs work » Needs review

#2: Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch, failed testing.

dbcollies’s picture

dbcollies commented

I think that there is something wrong with the test itself. Even on unpatched code, the test fails randomly for me. I have not yet tracked down what might be failing with the test.

I don't see how this patch could be causing this sort of error

dbcollies’s picture

dbcollies commented
Status: Needs work » Needs review
Issue tags: -Novice, -VDC

#2: Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch, failed testing.

dbcollies’s picture

dbcollies commented
Status: Needs work » Needs review

#2: Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch, failed testing.

dbcollies’s picture

dbcollies commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: Rename-Views-method-set_override_options-to-setOverrideOptions-2003274-1.patch queued for re-testing.

oenie’s picture

oenie commented
Title: Rename Views method set_override_options() to setOverrideOptions() » Rename Views method lgtm() to setOverrideOptions()
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

oenie’s picture

oenie commented
Title: Rename Views method lgtm() to setOverrideOptions() » Rename Views method set_override_options() to setOverrideOptions()

Oops.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed dd87cbc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.