Files: 
CommentFileSizeAuthor
#4 views-2003262-showOperatorForm.patch1.15 KBphenaproxima
PASSED: [[SimpleTest]]: [MySQL] 57,146 pass(es). View
#2 views-2003262-showOperatorForm.patch1.15 KBphenaproxima
PASSED: [[SimpleTest]]: [MySQL] 55,876 pass(es). View

Comments

phenaproxima’s picture

Assigned: Unassigned » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
1.15 KB
PASSED: [[SimpleTest]]: [MySQL] 55,876 pass(es). View
elvis2’s picture

Status: Needs review » Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

phenaproxima’s picture

Status: Needs work » Needs review
FileSize
1.15 KB
PASSED: [[SimpleTest]]: [MySQL] 57,146 pass(es). View

Added public modifier.

elvis2’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 29271d4 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.