Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 VDC-Rename_summary_sort-2002978-4.patch1.09 KBtvlooy
#4 VDC-Rename_summary_sort-2002978-4.patch1.09 KBtvlooy
#2 VDC-Rename_summary_sort-2002978-2.patch1.08 KBseantwalsh

Comments

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented
Assigned: Unassigned » seantwalsh
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

seantwalsh
he/him
Primary language English
Location Eatontown, NJ
commented
Status: Active » Needs review
StatusFileSize
new VDC-Rename_summary_sort-2002978-2.patch1.08 KB

Replaced 2 instances of summary_sort with summarySort.

elvis2’s picture

elvis2 commented
Status: Needs review » Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

tvlooy commented
Status: Needs work » Needs review
StatusFileSize
new VDC-Rename_summary_sort-2002978-4.patch1.09 KB

Added the access modifier.

tvlooy’s picture

tvlooy commented
StatusFileSize
new VDC-Rename_summary_sort-2002978-4.patch1.09 KB

Duplicate patch.

elvis2’s picture

elvis2 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4df1036 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.