Files: 
CommentFileSizeAuthor
#5 VDC-Rename_summary_sort-2002978-4.patch1.09 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 56,973 pass(es). View
#4 VDC-Rename_summary_sort-2002978-4.patch1.09 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 56,947 pass(es). View
#2 VDC-Rename_summary_sort-2002978-2.patch1.08 KBcrowdcg
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es). View

Comments

crowdcg’s picture

Assigned: Unassigned » crowdcg
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

crowdcg’s picture

Status: Active » Needs review
FileSize
1.08 KB
PASSED: [[SimpleTest]]: [MySQL] 55,920 pass(es). View

Replaced 2 instances of summary_sort with summarySort.

elvis2’s picture

Status: Needs review » Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

Status: Needs work » Needs review
FileSize
1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 56,947 pass(es). View

Added the access modifier.

tvlooy’s picture

FileSize
1.09 KB
PASSED: [[SimpleTest]]: [MySQL] 56,973 pass(es). View

Duplicate patch.

elvis2’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4df1036 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.