Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 15:22 UTC
Updated:
29 Jul 2014 at 22:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
diarmy commentedWorking on it!
Comment #2
diarmy commentedComment #3
diarmy commentedThe patch in #2 did not take into account instances of get_default_argument() used outside of the views module. After grepping the whole site, another example was located in core/modules/user/lib/Drupal/user/Tests/Views/ArgumentDefaultTest.php. This updated patch includes the conversion to getDefaultArgument for this too.
Comment #5
diarmy commented#3: 8.x-rename-views-method-2002900-3.patch queued for re-testing.
Comment #6
diarmy commentedJust realised that I need to add the public modifier before function getDefaultArgument() to adhere to OOP standards, so I'll get cracking with that.
Comment #7
diarmy commentedThis version includes the public modifier before function getDefaultArgument() in core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php.
Comment #8
oenie commentedAdd public access modifier in front of the function to adhere to the new OOP standards.
Comment #9
diarmy commentedI started over again, this time remembering to add the public access modifier in front of the function.
Comment #10
diarmy commentedUpdating status to needs review
Comment #11
dawehnerCool.
Comment #12
alexpottCommitted 0449064 and pushed to 8.x. Thanks!