Rename Views method get_argument() to getArgument()

Working on this as part of the Portland2013 getting involved with core sprint.

Replaced 11 instances of get_argument with getArgument.

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/argument_default/Node.phpundefined
@@ -24,7 +24,7 @@
+  function getArgument() {

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.phpundefined
@@ -117,7 +117,7 @@ public function submitOptionsForm(&$form, &$form_state, &$options = array()) {
+  function getArgument() {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument_default/CurrentUser.phpundefined
@@ -24,7 +24,7 @@
+  function getArgument() {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument_default/User.phpundefined
@@ -37,7 +37,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/ArgumentDefaultPluginBase.phpundefined
@@ -34,7 +34,7 @@
+  function getArgument() { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Fixed.phpundefined
@@ -41,7 +41,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Php.phpundefined
@@ -50,7 +50,7 @@ public function access() {
+  function getArgument() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Raw.phpundefined
@@ -49,7 +49,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getArgument() {

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/argument_default/ArgumentDefaultTest.phpundefined
@@ -32,9 +32,9 @@ protected function defineOptions() {
+  public function getArgument() {

Add public access modifier in front of the functions to adher to the new OOP standards.

Working on adding access modifier.

Added public access modifier. Thanks oenie!

Patch looks ok to me now! If it passed the testbot review, it's RTBC.

Unfortunately we need a reroll, the patch doesn't apply anymore.

Rerolled!

+++ b/core/modules/node/lib/Drupal/node/Plugin/views/argument_default/Node.phpundefined
@@ -24,7 +24,7 @@
+ public function getArgument() {

Wrong indentation.

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/argument_default/ArgumentDefaultTest.phpundefined
@@ -32,9 +32,9 @@ protected function defineOptions() {
+   * Overrides Drupal\views\Plugin\views\argument_default\ArgumentDefaultPluginBase::getArgument().

If we adapt it then properly: This should be @inheritdoc

Sorry about that, fixed indentation and updated with {@inheritdoc}.

Nice!

Needs a reroll

curl https://drupal.org/files/core-rename_get_argument_TO_getArgument-2002894-11.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6612  100  6612    0     0   7041      0 --:--:-- --:--:-- --:--:--  8609
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:744
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply

Reroll

Great!

Committed f1ba409 and pushed to 8.x. Thanks!