Rename Views method instantiate_view() to instantiateView()

I'm working on this at the DrupalCon Portland sprint.

Tests failing. Please investigate and re-roll a patch.

#2: views-rename-compile_fields-2002428-2.patch queued for re-testing.

Access modifier needs to be added to the function line as mentioned in the meta issue discussion:
http://drupal.org/node/1856630#comment-7451652

Should be "public function ..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1189,7 +1189,7 @@ function get_non_aggregates() {
-  function compile_fields($query) {
+ public function compileFields($query) {

Actually, protected seems more appropriate ($this->instantiateView) is the only call. Let's see if it keeps the testbot happy.

Let's try the right patch.

#8 looks good to me. All instances of the instantiate_view() method have been renamed. instantiateView() has been given protected visibility.

I think that #2 was mistakenly posted to the wrong issue. It should have gone into #2002428: Rename Views method compile_fields() to compileFields().

Committed 7790f21 and pushed to 8.x. Thanks!