See meta #2002650: [meta, no patch] improve maintainability by removing unused local variables

core/includes/file.inc

  • Unused local variable $original_destination (line 629)
CommentFileSizeAuthor
#2 performance-2002714.patch456 bytesneochief

Comments

neochief’s picture

neochief commented
Assigned: Unassigned » neochief
neochief’s picture

neochief commented
Status: Active » Needs review
StatusFileSize
new performance-2002714.patch456 bytes
kerasai’s picture

kerasai commented
Status: Needs review » Reviewed & tested by the community

Looks good. Nothing tricky and the testbot is happy.

catch’s picture

catch
he/him
Primary language English
commented
Title: Improve performance by removing unused local variables - core/includes/file.inc » Remove unused local variables - core/includes/file.inc
Status: Reviewed & tested by the community » Fixed

Unless this was done many thousands of times in the critical path (and possibly even then) I don't think it will show a measurable performance difference, however it's good cleanup and well spotted! Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.