See meta #2002650: [meta] improve maintainability by removing unused local variables

core/includes/file.inc

  • Unused local variable $original_destination (line 629)
Files: 
CommentFileSizeAuthor
#2 performance-2002714.patch456 bytesneochief
PASSED: [[SimpleTest]]: [MySQL] 55,890 pass(es).
[ View ]

Comments

neochief’s picture

Assigned:Unassigned» neochief
neochief’s picture

Status:Active» Needs review
StatusFileSize
new456 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,890 pass(es).
[ View ]
kerasai’s picture

Status:Needs review» Reviewed & tested by the community

Looks good. Nothing tricky and the testbot is happy.

catch’s picture

Title:Improve performance by removing unused local variables - core/includes/file.inc» Remove unused local variables - core/includes/file.inc
Status:Reviewed & tested by the community» Fixed

Unless this was done many thousands of times in the critical path (and possibly even then) I don't think it will show a measurable performance difference, however it's good cleanup and well spotted! Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.