Files: 
CommentFileSizeAuthor
#7 drupal-viewsRename-gather_headers-2002504-7.patch1.91 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 56,560 pass(es). View
#4 2002504-7450664-2.patch1.48 KBendorn
FAILED: [[SimpleTest]]: [MySQL] 55,709 pass(es), 1 fail(s), and 0 exception(s). View
#2 2002504-7450664.patch1.13 KBendorn
FAILED: [[SimpleTest]]: [MySQL] 55,878 pass(es), 2 fail(s), and 0 exception(s). View

Comments

endorn’s picture

Assigned: Unassigned » endorn
endorn’s picture

Status: Active » Needs review
FileSize
1.13 KB
FAILED: [[SimpleTest]]: [MySQL] 55,878 pass(es), 2 fail(s), and 0 exception(s). View

renamed the method.

hoZt’s picture

Status: Needs review » Needs work

Missed one: $this->gather_headers();

endorn’s picture

Status: Needs work » Needs review
FileSize
1.48 KB
FAILED: [[SimpleTest]]: [MySQL] 55,709 pass(es), 1 fail(s), and 0 exception(s). View

fixed.

Status: Needs review » Needs work

The last submitted patch, 2002504-7450664-2.patch, failed testing.

heddn’s picture

Tests failing. Please investigate and re-roll a patch.

heddn’s picture

Status: Needs work » Needs review
FileSize
1.91 KB
PASSED: [[SimpleTest]]: [MySQL] 56,560 pass(es). View

Let's try this.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5cd1a5f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.