Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 drupal-viewsRename-gather_headers-2002504-7.patch1.91 KBheddn
#4 2002504-7450664-2.patch1.48 KBSlayJay
#2 2002504-7450664.patch1.13 KBSlayJay

Comments

SlayJay’s picture

SlayJay commented
Assigned: Unassigned » SlayJay
SlayJay’s picture

SlayJay commented
Status: Active » Needs review
StatusFileSize
new 2002504-7450664.patch1.13 KB

renamed the method.

hozt’s picture

hozt commented
Status: Needs review » Needs work

Missed one: $this->gather_headers();

SlayJay’s picture

SlayJay commented
Status: Needs work » Needs review
StatusFileSize
new 2002504-7450664-2.patch1.48 KB

fixed.

Status: Needs review » Needs work

The last submitted patch, 2002504-7450664-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Tests failing. Please investigate and re-roll a patch.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-viewsRename-gather_headers-2002504-7.patch1.91 KB

Let's try this.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5cd1a5f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.