Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arh1’s picture

Assigned: Unassigned » arh1

Sprinting: I'll work on this!

arh1’s picture

Status: Active » Needs review
FileSize
1.38 KB

Patch attached.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-views_rename_exposed_translate_method-2002502-2.patch, failed testing.

oenie’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1106,7 +1106,7 @@ public function addGroupForm($form, &$form_state) {
+  function exposedTranslate(&$form, $type) {

Add protected access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

Status: Needs review » Needs work
arh1’s picture

Status: Needs work » Needs review
FileSize
1.39 KB

Thanks, oenie. Rerolled with the protected access modifier.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c7d2aab and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.