Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 drupal-views_rename_exposed_translate_method-2002502-7.patch1.39 KBarh1
#2 drupal-views_rename_exposed_translate_method-2002502-2.patch1.38 KBarh1

Comments

arh1’s picture

arh1 commented
Assigned: Unassigned » arh1

Sprinting: I'll work on this!

arh1’s picture

arh1 commented
Status: Active » Needs review
StatusFileSize
new drupal-views_rename_exposed_translate_method-2002502-2.patch1.38 KB

Patch attached.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-views_rename_exposed_translate_method-2002502-2.patch, failed testing.

oenie’s picture

oenie commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: drupal-views_rename_exposed_translate_method-2002502-2.patch queued for re-testing.

oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1106,7 +1106,7 @@ public function addGroupForm($form, &$form_state) {
+  function exposedTranslate(&$form, $type) {

Add protected access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

oenie commented
Status: Needs review » Needs work
arh1’s picture

arh1 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-views_rename_exposed_translate_method-2002502-7.patch1.39 KB

Thanks, oenie. Rerolled with the protected access modifier.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c7d2aab and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.