Files: 
CommentFileSizeAuthor
#9 views-2002498-exposedFormSubmit-8.patch2.47 KBdiarmy
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es). View
#9 interdiff.txt693 bytesdiarmy
#7 views-2002498-exposedFormSubmit-7.patch2.47 KBdiarmy
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php. View
#7 interdiff.txt885 bytesdiarmy
#6 views-2002498-exposedFormSubmit-6.patch2.46 KBdiarmy
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php. View
#2 views-2002498-exposedFormSubmit.patch2.46 KBphenaproxima
FAILED: [[SimpleTest]]: [MySQL] 55,709 pass(es), 1 fail(s), and 0 exception(s). View

Comments

phenaproxima’s picture

Assigned: Unassigned » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
2.46 KB
FAILED: [[SimpleTest]]: [MySQL] 55,709 pass(es), 1 fail(s), and 0 exception(s). View

This patch passed the general rendering and exposed form tests on my localhost.

Status: Needs review » Needs work

The last submitted patch, views-2002498-exposedFormSubmit.patch, failed testing.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -271,12 +271,12 @@ function exposed_form_validate(&$form, &$form_state) {
+  function exposedFormSubmit(&$form, &$form_state, &$exclude) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -243,7 +243,7 @@ function exposed_form_alter(&$form, &$form_state) { }
+  function exposedFormSubmit(&$form, &$form_state, &$exclude) { }

Add public access modifier in front of the functions to adher to the new OOP standards.

diarmy’s picture

Added public access modifier in front of the exposedFormSubmit() function in views

diarmy’s picture

FileSize
2.46 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php. View

Whoops! Forgot patch. :)

diarmy’s picture

Status: Needs work » Needs review
FileSize
885 bytes
2.47 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.php. View

This patch adds in second public modifier. #6 only amended one of them.

Status: Needs review » Needs work

The last submitted patch, views-2002498-exposedFormSubmit-7.patch, failed testing.

diarmy’s picture

Status: Needs work » Needs review
FileSize
693 bytes
2.47 KB
PASSED: [[SimpleTest]]: [MySQL] 55,901 pass(es). View

Public modifier had been placed after 'function' in line 246 of PagerPluginBase.php. It has now been placed before.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

Thank you. This looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5202f71 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.