Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 drupal-camelcase-replace.2002496.6.patch3.05 KBbaldwinlouie
#3 drupal-camelcase-replace-2002496.3.patch3.46 KBbaldwinlouie
#2 drupal-camelcase-replace-2002496-7450426.patch3.46 KBbaldwinlouie

Comments

baldwinlouie’s picture

baldwinlouie commented
Assigned: Unassigned » baldwinlouie

taking by baldwinlouie and sillygwilo

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new drupal-camelcase-replace-2002496-7450426.patch3.46 KB

attaching patch

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new drupal-camelcase-replace-2002496.3.patch3.46 KB

rerolling with access modifier

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2002496.3.patch, failed testing.

oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -239,7 +239,7 @@ function has_more_records() {
+  function exposedFormAlter(&$form, &$form_state) { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/SqlBase.phpundefined
@@ -335,7 +335,7 @@ function offset_exposed() {
+  function exposedFormAlter(&$form, &$form_state) {

Still missing some public access modifiers.

+++ b/core/modules/views/views.moduleundefined
@@ -1489,7 +1489,7 @@ function views_exposed_form($form, &$form_state) {
-function views_form_views_exposed_form_alter(&$form, &$form_state) {
+function views_form_views_exposedFormAlter(&$form, &$form_state) {

This is an incorrect replacement. You are changing the name of a hook, which subsequently will never be called anymore. Should stay as is. (although the hook-system is on it's way out if i'm not mistaken)

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review
StatusFileSize
new drupal-camelcase-replace.2002496.6.patch3.05 KB

Rerolled with correct modifiers.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

No calls left, and patch still applies.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c481e2f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.