Files: 
CommentFileSizeAuthor
#4 views-executeCountQuery-2002490-4.patch1.99 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,897 pass(es).
[ View ]
#2 Rename-Views-method-execute_count_query-to-executeCountQuery-issue-number-2002490-comment-7450112.patch1.97 KBthemic8
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

themic8’s picture

Assigned:Unassigned» themic8

Working on for DrupalCon Portland.

themic8’s picture

Assigned:themic8» Unassigned
Status:Active» Needs review
StatusFileSize
new1.97 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/None.phpundefined
@@ -75,7 +75,7 @@ function get_items_per_page() {
+  function executeCountQuery(&$count_query) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -177,7 +177,7 @@ function use_count_query() {
+  function executeCountQuery(&$count_query) {

Add public access modifier in front of the functions to adher to the new OOP standards.

JeroenT’s picture

Status:Needs work» Needs review
StatusFileSize
new1.99 KB
PASSED: [[SimpleTest]]: [MySQL] 55,897 pass(es).
[ View ]

rename method execute_count_query to executeCountQuery.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 3a4632c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.