It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Related to the Views in Drupal Core initiative.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Working on for DrupalCon Portland.
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/None.phpundefined @@ -75,7 +75,7 @@ function get_items_per_page() { + function executeCountQuery(&$count_query) { +++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined @@ -177,7 +177,7 @@ function use_count_query() { + function executeCountQuery(&$count_query) {
Add public access modifier in front of the functions to adher to the new OOP standards.
rename method execute_count_query to executeCountQuery.
Looks good to me now !
Committed 3a4632c and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
themic8 commentedWorking on for DrupalCon Portland.
Comment #2
themic8 commentedComment #3
oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #4
jeroentrename method execute_count_query to executeCountQuery.
Comment #5
oenie commentedLooks good to me now !
Comment #6
alexpottCommitted 3a4632c and pushed to 8.x. Thanks!