Comments

themic8’s picture

Assigned: Unassigned » themic8

Working on for DrupalCon Portland.

themic8’s picture

Assigned: themic8 » Unassigned
Status: Active » Needs review
StatusFileSize
new1.97 KB
oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/None.phpundefined
@@ -75,7 +75,7 @@ function get_items_per_page() {
+  function executeCountQuery(&$count_query) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -177,7 +177,7 @@ function use_count_query() {
+  function executeCountQuery(&$count_query) {

Add public access modifier in front of the functions to adher to the new OOP standards.

jeroent’s picture

Status: Needs work » Needs review
StatusFileSize
new1.99 KB

rename method execute_count_query to executeCountQuery.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 3a4632c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.