Comments

seantwalsh’s picture

Assigned: Unassigned » seantwalsh

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

Status: Active » Needs review
StatusFileSize
new3.63 KB

Replaced 7 instances of even_empty with evenEmpty.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/views/style/EntityReference.phpundefined
@@ -102,9 +102,9 @@ public function render() {
+  function evenEmpty() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -212,7 +212,7 @@ function tokenize_value($value, $row_index) {
+  function evenEmpty() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -387,8 +387,8 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function evenEmpty() {

Add public access modifier in front of the functions to adher to the new OOP standards.

shixish’s picture

StatusFileSize
new1.83 KB
new3.65 KB

Added public to the function definitions.

shixish’s picture

Status: Needs work » Needs review
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine by me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2002486-added-access-modifier-4.diff, failed testing.

seantwalsh’s picture

Status: Needs work » Needs review
StatusFileSize
new3.65 KB

Submitting updated patch for retesting.

dawehner’s picture

Thanks for all your help!

+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/views/style/EntityReference.phpundefined
@@ -102,9 +102,9 @@ public function render() {
+   * Overrides \Drupal\views\Plugin\views\style\StylePluginBase\StylePluginBase::evenEmpty().

Let's do a @inheritdoc, please

seantwalsh’s picture

Sorry about that, updated with {@inheritdoc}.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Another issue, great!

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, core-rename_even_empty_TO_evenEmpty-2002486-10.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, core-rename_even_empty_TO_evenEmpty-2002486-10.patch, failed testing.

joelpittet’s picture

+++ b/core/modules/views/views.theme.inc
@@ -52,6 +52,7 @@ function _views_theme_functions($hook, ViewExecutable $view, $display = NULL) {
   global $base_path;
 
+  $vars['rows'] = (!empty($view->result) || $view->style_plugin->evenEmpty()) ? $view->style_plugin->render($view->result) : '';
   $view = $vars['view'];
 

Looks like the new line was meant to replace the line 3 rows down from that one.

seantwalsh’s picture

Status: Needs work » Needs review
StatusFileSize
new3.6 KB

Thanks, not sure what happened there. This one should pass.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice

Already RTBC'd by @dawehner in #11 and it's green now. So back to it:) Thank you @crowdcg

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c4e1535 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary. Added commit line.