Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 03:57 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 7 instances of even_empty with evenEmpty.
Comment #3
oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #4
shixish commentedAdded public to the function definitions.
Comment #5
shixish commentedComment #6
oenie commentedLooks fine by me.
Comment #8
seantwalshSubmitting updated patch for retesting.
Comment #9
dawehnerThanks for all your help!
Let's do a @inheritdoc, please
Comment #10
seantwalshSorry about that, updated with {@inheritdoc}.
Comment #11
dawehnerAnother issue, great!
Comment #13
dawehner#10: core-rename_even_empty_TO_evenEmpty-2002486-10.patch queued for re-testing.
Comment #15
joelpittetLooks like the new line was meant to replace the line 3 rows down from that one.
Comment #16
seantwalshThanks, not sure what happened there. This one should pass.
Comment #17
joelpittetAlready RTBC'd by @dawehner in #11 and it's green now. So back to it:) Thank you @crowdcg
Comment #18
alexpottCommitted c4e1535 and pushed to 8.x. Thanks!
Comment #19.0
(not verified) commentedUpdated issue summary. Added commit line.