Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 rename-view-method-2002478-5.patch1.38 KBAri Gold
#3 rename-view-method-2002478-3.patch1.37 KBAri Gold
#2 rename-view-method-2002478-2.patch636 bytesAri Gold

Comments

Ari Gold’s picture

Ari Gold commented
Assigned: Unassigned » Ari Gold
Ari Gold’s picture

Ari Gold commented
Status: Active » Needs review
StatusFileSize
new rename-view-method-2002478-2.patch636 bytes

Patch attached.

Ari Gold’s picture

Ari Gold commented
StatusFileSize
new rename-view-method-2002478-3.patch1.37 KB

Rerolled patch.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -349,7 +349,7 @@ function element_label_classes($row_index = NULL) {
+  function elementWrapperClasses($row_index = NULL) {

Add public access modifier in front of the function to adher to the new OOP standards.

Ari Gold’s picture

Ari Gold commented
Status: Needs work » Needs review
StatusFileSize
new rename-view-method-2002478-5.patch1.38 KB

Rerolled patch.

Are the new OOP coding standards documented?

Ari Gold’s picture

Ari Gold commented

I now see that comment #28 in https://drupal.org/node/1856630 suggests that public is a good default.

oenie’s picture

oenie commented

It kind of depends on how the function is used.
If it's a function that's only used from a class instance itself ($this->elementWrapperClasses), you could set it to protected.
But public usually is a safe bet.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine now.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.